STM32LTDC: DMA2D enabling might be too late #2

Closed
opened 2 months ago by jbo · 2 comments
jbo commented 2 months ago
Owner

The following snipped is located in /drivers/gdisp/STM32LTDC/gdisp_lld_STM32LTDC.h:

#if LTDC_USE_DMA2D
	// DMA2D supports accelerated fills
 	#define GDISP_HARDWARE_FILLS		GFXON

	// Accelerated bitfills are also possible but only for gOrientation0
	//	and if no color translation is required (for now)
	#if !GDISP_NEED_CONTROL && !defined(GDISP_PIXELFORMAT)
 		#define GDISP_HARDWARE_BITFILLS	GFXON
	#endif
#endif /* GDISP_USE_DMA2D */

However, this snipped is processed before the board file gets included.

This needs some investigation/checking/testing/fixing.

We might not be able to set LTDC_USE_DMA2D in the board file and might need to resort to setting it in the global gfxconf.h similar to how we set GDISP_LTDC_USE_RGB565 in gfxconf.h if needed.

The following snipped is located in `/drivers/gdisp/STM32LTDC/gdisp_lld_STM32LTDC.h`: ```c #if LTDC_USE_DMA2D // DMA2D supports accelerated fills #define GDISP_HARDWARE_FILLS GFXON // Accelerated bitfills are also possible but only for gOrientation0 // and if no color translation is required (for now) #if !GDISP_NEED_CONTROL && !defined(GDISP_PIXELFORMAT) #define GDISP_HARDWARE_BITFILLS GFXON #endif #endif /* GDISP_USE_DMA2D */ ``` However, this snipped is processed before the board file gets included. This needs some investigation/checking/testing/fixing. We might not be able to set `LTDC_USE_DMA2D` in the board file and might need to resort to setting it in the global `gfxconf.h` similar to how we set `GDISP_LTDC_USE_RGB565` in `gfxconf.h` if needed.
Poster
Owner

Confirmed: We need to either do this in the config file or the gfxconf.h.

We're therefore going to "expose" all STM32LTDC driver related options to gfxconf.h.

Confirmed: We need to either do this in the config file or the `gfxconf.h`. We're therefore going to "expose" all STM32LTDC driver related options to `gfxconf.h`.
Poster
Owner

Fixed.

Fixed.
jbo closed this issue 2 months ago
Sign in to join this conversation.
No Label
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.