uGFX/ugfx
2
0
Fork 0
Code Issues 2 Pull requests Projects Releases Wiki Activity

STM32LTDC: DMA2D enabling might be too late #2

New issue
Closed
opened 2021-08-17 11:47:15 +00:00 by jbo · 2 comments
jbo commented 2021-08-17 11:47:15 +00:00
Owner
Copy link

The following snipped is located in /drivers/gdisp/STM32LTDC/gdisp_lld_STM32LTDC.h:

#if LTDC_USE_DMA2D
	// DMA2D supports accelerated fills
 	#define GDISP_HARDWARE_FILLS		GFXON

	// Accelerated bitfills are also possible but only for gOrientation0
	//	and if no color translation is required (for now)
	#if !GDISP_NEED_CONTROL && !defined(GDISP_PIXELFORMAT)
 		#define GDISP_HARDWARE_BITFILLS	GFXON
	#endif
#endif /* GDISP_USE_DMA2D */

However, this snipped is processed before the board file gets included.

This needs some investigation/checking/testing/fixing.

We might not be able to set LTDC_USE_DMA2D in the board file and might need to resort to setting it in the global gfxconf.h similar to how we set GDISP_LTDC_USE_RGB565 in gfxconf.h if needed.

The following snipped is located in `/drivers/gdisp/STM32LTDC/gdisp_lld_STM32LTDC.h`: ```c #if LTDC_USE_DMA2D // DMA2D supports accelerated fills #define GDISP_HARDWARE_FILLS GFXON // Accelerated bitfills are also possible but only for gOrientation0 // and if no color translation is required (for now) #if !GDISP_NEED_CONTROL && !defined(GDISP_PIXELFORMAT) #define GDISP_HARDWARE_BITFILLS GFXON #endif #endif /* GDISP_USE_DMA2D */ ``` However, this snipped is processed before the board file gets included. This needs some investigation/checking/testing/fixing. We might not be able to set `LTDC_USE_DMA2D` in the board file and might need to resort to setting it in the global `gfxconf.h` similar to how we set `GDISP_LTDC_USE_RGB565` in `gfxconf.h` if needed.
jbo commented 2021-08-17 12:09:17 +00:00
Author
Owner
Copy link

Confirmed: We need to either do this in the config file or the gfxconf.h.

We're therefore going to "expose" all STM32LTDC driver related options to gfxconf.h.

Confirmed: We need to either do this in the config file or the `gfxconf.h`. We're therefore going to "expose" all STM32LTDC driver related options to `gfxconf.h`.
jbo commented 2021-08-18 19:02:25 +00:00
Author
Owner
Copy link

Fixed.

Fixed.
jbo closed this issue 2021-08-18 19:02:25 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
feature/mf_upgrade
feature/ssd1312
feature/sdl2_threaded
develop
spinbox_widget
v2.9
v2.8
v2.7
v2.6
v2.5
v2.4
v2.3
v2.2
v2.1
v2.0
v1.9
v1.8
v1.7
v1.1
v1.2
v1.3
v1.4
v1.5
v1.6
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: uGFX/ugfx#2
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?