STM32LTDC: DMA2D enabling might be too late #2

New Issue

jbo · 2021-08-17T11:47:15Z

jbo commented

2021-08-17 11:47:15 +00:00

The following snipped is located in /drivers/gdisp/STM32LTDC/gdisp_lld_STM32LTDC.h:

#if LTDC_USE_DMA2D
	// DMA2D supports accelerated fills
 	#define GDISP_HARDWARE_FILLS		GFXON

	// Accelerated bitfills are also possible but only for gOrientation0
	//	and if no color translation is required (for now)
	#if !GDISP_NEED_CONTROL && !defined(GDISP_PIXELFORMAT)
 		#define GDISP_HARDWARE_BITFILLS	GFXON
	#endif
#endif /* GDISP_USE_DMA2D */

However, this snipped is processed before the board file gets included.

This needs some investigation/checking/testing/fixing.

We might not be able to set LTDC_USE_DMA2D in the board file and might need to resort to setting it in the global gfxconf.h similar to how we set GDISP_LTDC_USE_RGB565 in gfxconf.h if needed.

The following snipped is located in `/drivers/gdisp/STM32LTDC/gdisp_lld_STM32LTDC.h`: ```c #if LTDC_USE_DMA2D // DMA2D supports accelerated fills #define GDISP_HARDWARE_FILLS GFXON // Accelerated bitfills are also possible but only for gOrientation0 // and if no color translation is required (for now) #if !GDISP_NEED_CONTROL && !defined(GDISP_PIXELFORMAT) #define GDISP_HARDWARE_BITFILLS GFXON #endif #endif /* GDISP_USE_DMA2D */ ``` However, this snipped is processed before the board file gets included. This needs some investigation/checking/testing/fixing. We might not be able to set `LTDC_USE_DMA2D` in the board file and might need to resort to setting it in the global `gfxconf.h` similar to how we set `GDISP_LTDC_USE_RGB565` in `gfxconf.h` if needed.

jbo commented

2021-08-17 12:09:17 +00:00

Poster

Confirmed: We need to either do this in the config file or the gfxconf.h.

We're therefore going to "expose" all STM32LTDC driver related options to gfxconf.h.

Confirmed: We need to either do this in the config file or the `gfxconf.h`. We're therefore going to "expose" all STM32LTDC driver related options to `gfxconf.h`.

jbo commented

2021-08-18 19:02:25 +00:00

Poster

Fixed.

jbo closed this issue

2021-08-18 19:02:25 +00:00

Sign in to join this conversation.

No Label

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: uGFX/ugfx#2